Skip to content

Conversation

ianayl
Copy link
Contributor

@ianayl ianayl commented May 6, 2025

Previously, there was no way to figure out what version of compute-runtime we were using. This PR:

  • adds a way to detect compute-runtime version via looking up L0 patch version in compute-runtime releases
    • adds a way to pre-specify a compute-runtime version that should be used before looking up L0 patch in compute-runtime releases
  • additionally, adds a way to automatically detect SYCL version via __clang_version__

@ianayl ianayl requested review from a team as code owners May 6, 2025 15:29
@ianayl ianayl temporarily deployed to WindowsCILock May 6, 2025 15:48 — with GitHub Actions Inactive
@ianayl ianayl temporarily deployed to WindowsCILock May 6, 2025 16:22 — with GitHub Actions Inactive
@ianayl ianayl temporarily deployed to WindowsCILock May 6, 2025 16:22 — with GitHub Actions Inactive
@ianayl ianayl temporarily deployed to WindowsCILock May 6, 2025 18:41 — with GitHub Actions Inactive
@ianayl ianayl temporarily deployed to WindowsCILock May 6, 2025 19:03 — with GitHub Actions Inactive
@ianayl ianayl temporarily deployed to WindowsCILock May 6, 2025 19:03 — with GitHub Actions Inactive
@ianayl ianayl temporarily deployed to WindowsCILock May 7, 2025 21:44 — with GitHub Actions Inactive
@ianayl ianayl temporarily deployed to WindowsCILock May 7, 2025 22:02 — with GitHub Actions Inactive
@ianayl ianayl temporarily deployed to WindowsCILock May 7, 2025 22:02 — with GitHub Actions Inactive
@ianayl ianayl temporarily deployed to WindowsCILock May 28, 2025 22:24 — with GitHub Actions Inactive
@ianayl ianayl temporarily deployed to WindowsCILock May 28, 2025 22:45 — with GitHub Actions Inactive
@ianayl ianayl temporarily deployed to WindowsCILock May 28, 2025 22:45 — with GitHub Actions Inactive
@ianayl ianayl temporarily deployed to WindowsCILock May 28, 2025 23:00 — with GitHub Actions Inactive
@ianayl ianayl temporarily deployed to WindowsCILock May 28, 2025 23:22 — with GitHub Actions Inactive
@ianayl ianayl temporarily deployed to WindowsCILock May 28, 2025 23:22 — with GitHub Actions Inactive
@ianayl ianayl temporarily deployed to WindowsCILock May 28, 2025 23:50 — with GitHub Actions Inactive
@ianayl ianayl requested a review from pbalcer May 28, 2025 23:53
@ianayl ianayl temporarily deployed to WindowsCILock May 29, 2025 00:12 — with GitHub Actions Inactive
@ianayl ianayl temporarily deployed to WindowsCILock May 29, 2025 00:12 — with GitHub Actions Inactive
@ianayl ianayl temporarily deployed to WindowsCILock May 29, 2025 15:46 — with GitHub Actions Inactive
@ianayl ianayl temporarily deployed to WindowsCILock May 29, 2025 16:35 — with GitHub Actions Inactive
@ianayl ianayl temporarily deployed to WindowsCILock May 29, 2025 16:35 — with GitHub Actions Inactive
@ianayl ianayl temporarily deployed to WindowsCILock May 30, 2025 21:02 — with GitHub Actions Inactive
@ianayl ianayl temporarily deployed to WindowsCILock May 30, 2025 21:48 — with GitHub Actions Inactive
@ianayl ianayl temporarily deployed to WindowsCILock May 30, 2025 21:48 — with GitHub Actions Inactive
@ianayl
Copy link
Contributor Author

ianayl commented Jun 2, 2025

@intel/dpcpp-devops-reviewers Can I get a review please? Thanks!

# check with L0 version before using it: This value is not guaranteed to
# accurately reflect the current compute_runtime version used, as the
# docker images are built nightly.
export COMPUTE_RUNTIME_TAG_CACHE="$(cat ./devops/dependencies.json | jq -r .linux.compute_runtime.github_tag)"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this envvar needed outside of this current script? if so we need to set it in a different way

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is only needed in the main.py script ran immediately below this, which is why I haven't put it in GITHUB_ENV

Copy link
Contributor

@sarnex sarnex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm from overall devops pov, benchmarking specific behavior is left to benchmarking review group

@sarnex sarnex merged commit 101c8d8 into sycl Jun 2, 2025
25 of 26 checks passed
@ianayl
Copy link
Contributor Author

ianayl commented Jun 2, 2025

I had thought I left links of test runs here, but I guess I forgot: (this covers benchmarking scripts behavior)

Here is run where dependencies.json versions match nightly container: https://github.com/intel/llvm/actions/runs/15355734380/job/43214988559
Here is run where nightly container version differs from dependency.json (thus quering the github API needed): https://github.com/intel/llvm/actions/runs/15312278338/job/43079573537

Both runs are failures as there are regressions in L0: I will address this in an upcoming PR

@bader bader deleted the ianayl/benchmark-ci-detect-version branch June 3, 2025 22:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants