-
Notifications
You must be signed in to change notification settings - Fork 790
[CI][Benchmarks] Automatically detect component versions in benchmark CI #18339
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…hmark-ci-detect-version
…hmark-ci-detect-version
@intel/dpcpp-devops-reviewers Can I get a review please? Thanks! |
# check with L0 version before using it: This value is not guaranteed to | ||
# accurately reflect the current compute_runtime version used, as the | ||
# docker images are built nightly. | ||
export COMPUTE_RUNTIME_TAG_CACHE="$(cat ./devops/dependencies.json | jq -r .linux.compute_runtime.github_tag)" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is this envvar needed outside of this current script? if so we need to set it in a different way
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is only needed in the main.py script ran immediately below this, which is why I haven't put it in GITHUB_ENV
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm from overall devops pov, benchmarking specific behavior is left to benchmarking review group
I had thought I left links of test runs here, but I guess I forgot: (this covers benchmarking scripts behavior) Here is run where dependencies.json versions match nightly container: https://github.com/intel/llvm/actions/runs/15355734380/job/43214988559 Both runs are failures as there are regressions in L0: I will address this in an upcoming PR |
Previously, there was no way to figure out what version of compute-runtime we were using. This PR:
__clang_version__